Effective Code Review

Location: Portland 256 Level: Intermediate
Average rating: ***..
(3.32, 38 ratings)

I’m an energetic, 20-something-year-old software developer from Ottawa, Canada. In 2011 I spoke at Microsoft MIX and at SenchaCon. Please consider my proposal for speaking at OSCON 2012!

I would like to propose a talk centered around code review. This is a common practice in the open-source community, but it’s very rare in commercial development. My talk would explain how we adopted code review after working on Wine, why this is one of the smartest things we have ever done as a company, and why/how others can do this as well.

Here are the major points and sub-points I propose to cover:

  • Introduction
    • What we learned while working on Wine.
    • Why we chose to adopt code review.
  • What are the benefits of code review?
    • Better code!
    • Broader understanding of the codebase.
    • Learning to be a better developer.
  • Getting the most out of code review.
    • What does high-quality code look like?
    • What to look for, and how to find it.
    • What’s not important?
  • How does this work in a geographically-dispersed team?
    • Asynchronous code review.
    • The reviewer-committer paradigm.
    • Taking advantage of timezone differences.
  • Where source control fits in.
    • SVN vs Git
    • Benefits of related technologies (GitHub, Gerrit, etc)
  • How to sell code review to others.
    • A fun story about how we convinced a small programming class at a local high school to use code review. (With fantastic results!)
    • How to sell code review to your boss.
  • Conclusion
    • Why code review works for open source projects.
    • Why code review works for us, and for teenagers in high school.
    • Why code review can work for you.

Thank you for your consideration!

Photo of Dan Menard

Dan Menard


Hi! My name is Dan, and I build beautiful, high-performance user interfaces at Netflix.

I’m originally from Ottawa, Canada, now living in California. When I’m not building HTML5 applications, you can often find me reading or writing about programming and best practices online.

I have a highly irrational fear of sharks, and I adore maple syrup. To learn more about me, and maybe how to write better code, check out my talk on Effective Code Review!

Comments on this page are now closed.


Chris Pall
07/24/2012 12:46am PDT

I thought the presentation was going to be more about how to do effective code review—not selling the idea of code review.

Picture of Shirley Bailes
Shirley Bailes
07/23/2012 6:49am PDT

@Mark: The PPT is now posted.

Mark Russo
07/23/2012 6:30am PDT

Downloading the presentation to my Mac isn’t giving me a useful set of files. I ended up with a set of file files, all with no file extension. Here are the file names: Current User, DocumentSummaryInformation, Pictures, PowerPoint Document, SummaryInformation.

Is the file damaged? Or are there special unarchiving instructions?


For information on exhibition and sponsorship opportunities at the conference, contact Sharon Cordesse at (707) 827-7065 or scordesse@oreilly.com.

View a complete list of OSCON contacts